-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strings for new spells and door #3490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 239 - Bad string for a SELF_BUFF, so fixed 654 - the 'Monster' part means you target another. Removed LMB so it can be used for a RANGED SPEED creature spell buff 655 - the 'Monster' part means you target another. Removed LMB so it can be used for a RANGED PROTECT creature spell buff 656 - the 'Monster' part means you target another. Removed LMB so it can be used for a RANGED INVISIBILITY creature spell buff 1053 - String was made for new Keeper Rebound spell, gave it a different name so it is distinct from rebound SELF_BUFF. 1056 - String was made for new Keeper Flight spell, gave it a different name so it is distinct from flight SELF_BUFF. 1058 - Gave it a description it was lacking. Can be used for ranged buff creature spell as well as keeper power. 1066 - Quite similar to 'heal' keeper power, but added 'Monster' to match other spell/power names with monster in it to target others. This instead of changing the keeper power to HEAL MONSTER too. 1067 to 1070 to be used for future creature spells. 1071 - new midas door name 1072 - the full tooltip for the midas door
Loobinex
force-pushed
the
newstrings
branch
2 times, most recently
from
September 24, 2024 22:58
568b70f
to
e10d701
Compare
Loobinex
force-pushed
the
newstrings
branch
from
September 24, 2024 22:58
e10d701
to
7f199b4
Compare
Merged
Co-Authored-By: benlp91 <[email protected]>
also dutch tweaks per Yani
Loobinex
force-pushed
the
newstrings
branch
from
September 26, 2024 15:32
780f768
to
b3a63f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
239 - Bad string for a SELF_BUFF, so fixed
654 - the 'Monster' part means you target another. Removed LMB so it can be used for a RANGED SPEED creature spell buff
655 - the 'Monster' part means you target another. Removed LMB so it can be used for a RANGED PROTECT creature spell buff
656 - the 'Monster' part means you target another. Removed LMB so it can be used for a RANGED INVISIBILITY creature spell buff
1053/1056 - Gave it a different name so it is distinct from flight SELF_BUFF.
1066 - Quite similar to 'heal' keeper power, but added 'Monster' to match other spell/power names with monster in it to target others. This instead of changing the keeper power to HEAL MONSTER too.
1067/1068 - cleanse creature spell which is hopefully a creature spell soon
1069/1070/1071 - Descriptions for the recent Keeper powers, that can also be used for Creature Ranged Buffs
1072~1075 - placeholders for future powers/spells
1076 - new midas door name
1077 - the full tooltip for the midas door